git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] t0000: simplify HARNESS_ACTIVE hack

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Dec 28, 2013, 22:14 UTC
Message-ID
<20131228221417.GC5544@google.com>
In-Reply-To
<20131228093149.GB21109@sigill.intra.peff.net>
Jeff King wrote:
Show 16 quoted lines
> --- a/t/t0000-basic.sh
> +++ b/t/t0000-basic.sh
> @@ -50,11 +50,11 @@ run_sub_test_lib_test () {
>  	shift 2
>  	mkdir "$name" &&
>  	(
> -		# Pretend we're a test harness.  This prevents
> -		# test-lib from writing the counts to a file that will
> -		# later be summarized, showing spurious "failed" tests
> -		HARNESS_ACTIVE=t &&
> -		export HARNESS_ACTIVE &&
> +		# Pretend we're not running under a test harness, whether we
> +		# are or not. The test-lib output depends on the setting of
> +		# this variable, so we need a stable setting under which to run
> +		# the sub-test.
> +		sane_unset HARNESS_ACTIVE &&
Makes sense.

Thanks, Jonathan

Previous: Jeff KingNext: Jeff King
Message 7 of 18 in “t0000 cleanups”
  1. 0/3 t0000 cleanupsJeff King, Dec 28, 2013
  2. 1/3 t0000: set TEST_OUTPUT_DIRECTORY for sub-testsJeff King, Dec 28, 2013
  3. Jonathan NiederDec 28, 2013
  4. Jonathan NiederDec 28, 2013
  5. Jeff KingDec 29, 2013
  6. 2/3 t0000: simplify HARNESS_ACTIVE hackJeff King, Dec 28, 2013
  7. Jonathan NiederDec 28, 2013
  8. 3/3 t0000: drop "known breakage" testJeff King, Dec 28, 2013
  9. Jonathan NiederDec 28, 2013
  10. Jeff KingDec 29, 2013
  11. Jonathan NiederDec 28, 2013
  12. Junio C HamanoDec 30, 2013
  13. Jonathan NiederDec 30, 2013
  14. Junio C HamanoDec 30, 2013
  15. Jeff KingDec 31, 2013
  16. Jonathan NiederJan 2, 2014
  17. Junio C HamanoJan 2, 2014
  18. Jeff KingJan 3, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.