Re: [PATCH v4 2/2] Rename suffixcmp() to ends_with() and invert its result

From: Christian Couder <chriscool@tuxfamily.org>
Date: Nov 19, 2013, 21:04 UTC
Message-ID: <20131119.220438.1634671089949485179.chriscool@tuxfamily.org>
In-Reply-To: <20131119191322.GA4212@google.com>

From: Jonathan Nieder <jrnieder@gmail.com>

Show 11 quoted lines

> Christian Couder wrote:
> 
>> And in vcs-svn/fast_export.c there was already an ends_with()
>> function that did the same thing. Let's used the renamed one
>> while at it.
> 
> Yes, despite the change in signature this shouldn't slow anything
> down.  Thanks.
> 
> For what it's worth,
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks.

To avoid spamming the list again, I am going to send the following patches from the 86 patch long series to replace prefixcmp() with starts_with():

[PATCH v2 00/86] replace prefixcmp() with starts_with() [PATCH v2 01/86] strbuf: add starts_with() to be used instead of prefixcmp() [PATCH v2 02/86] diff: replace prefixcmp() with starts_with() [PATCH v2 08/86] transport*: replace prefixcmp() with starts_with() [PATCH v2 40/86] environment: replace prefixcmp() with starts_with() [PATCH v2 86/86] strbuf: remove prefixcmp() as it has been replaced with starts_with()

If there are no problems with them, then I will suppose that most of the patches are ok and probably send them all unless I am asked not to.

Cheers, Christian.