git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/2] Update documentation for http.continue option

From
Jeff King <peff@peff.net>
Date
Oct 25, 2013, 07:17 UTC
Message-ID
<20131025071706.GA17029@sigill.intra.peff.net>
In-Reply-To
<20131023225632.GZ865149@vauxhall.crustytoothpaste.net>
On Wed, Oct 23, 2013 at 10:56:32PM +0000, brian m. carlson wrote:
Show 12 quoted lines
> On Tue, Oct 22, 2013 at 08:21:48PM -0700, Shawn Pearce wrote:
> > From my perspective, it is OK to defaulting to use 100-continue if the
> > server supports Negotiate. If the user is stuck behind a broken proxy
> > and can't authenticate, they can't authenticate. They can either set
> > the variable to false, or fix their proxy, or use a different server,
> > etc.
> 
> I think Jonathan's suggestion was to get rid of the variable altogether
> and simply make the code conditional on whether the server is offering
> GSS-Negotiate.  I plan to make the use of 100-continue conditional on
> large_request as well, so that it only covers the case where it would
> otherwise fail.

I think that makes sense. Would you also want to suppress the probe request in that case? It serves the same purpose, but would cause you to do an extra auth for no reason (which potentially means user input, which is annoying).

Also, if I recall your original complaint correctly, the "Expect" handling was only half of the problem. Wasn't there also an issue where git prompts for a password, even though GSS-Negotiate doesn't use it? Do you have a plan for that?

-Peff
Previous: brian m. carlsonNext: brian m. carlson
Message 15 of 18 in “HTTP GSS-Negotiate improvements”
  1. 0/2 HTTP GSS-Negotiate improvementsbrian m. carlson, Oct 11, 2013
  2. 1/2 http: add option to enable 100 Continue responsesbrian m. carlson, Oct 11, 2013
  3. Jonathan NiederOct 11, 2013
  4. brian m. carlsonOct 12, 2013
  5. 2/2 Update documentation for http.continue optionbrian m. carlson, Oct 11, 2013
  6. Jonathan NiederOct 11, 2013
  7. brian m. carlsonOct 12, 2013
  8. brian m. carlsonOct 18, 2013
  9. Junio C HamanoOct 22, 2013
  10. Jonathan NiederOct 22, 2013
  11. Jonathan NiederOct 23, 2013
  12. brian m. carlsonOct 23, 2013
  13. Shawn PearceOct 23, 2013
  14. brian m. carlsonOct 23, 2013
  15. Jeff KingOct 25, 2013
  16. brian m. carlsonOct 25, 2013
  17. Junio C HamanoOct 23, 2013
  18. brian m. carlsonOct 23, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.