git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/2] http: add option to enable 100 Continue responses

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Oct 12, 2013, 00:03 UTC
Message-ID
<20131012000334.GD79408@vauxhall.crustytoothpaste.net>
In-Reply-To
<20131011234307.GU9464@google.com>
On Fri, Oct 11, 2013 at 04:43:07PM -0700, Jonathan Nieder wrote:
> "By default" means "when allowed to make its own choice", right?  (i.e.,
> the behavior git never gave libcurl a chance to try :))
> 
> Makes sense.

Yes, at least according to Daniel Stenberg. I don't believe it is ever triggered the way that git calls curl with CURLOPT_READFUNCTION, but I can't be certain since I haven't looked at the source code.

> Style: git tends to omit the '= 0' implicit for globals, since they are
> already 0 by default.
Okay.
> 	/*
> 	 * Multi-line comments in git have the starting and ending comment
> 	 * delimiters on their own lines, like this.
> 	 */

It wasn't clear from the existing code which way was being used, and the CodingGuidelines file didn't seem to cover it. I'll send a patch.

-- 
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
Previous: Jonathan NiederNext: brian m. carlson
Message 4 of 18 in “HTTP GSS-Negotiate improvements”
  1. 0/2 HTTP GSS-Negotiate improvementsbrian m. carlson, Oct 11, 2013
  2. 1/2 http: add option to enable 100 Continue responsesbrian m. carlson, Oct 11, 2013
  3. Jonathan NiederOct 11, 2013
  4. brian m. carlsonOct 12, 2013
  5. 2/2 Update documentation for http.continue optionbrian m. carlson, Oct 11, 2013
  6. Jonathan NiederOct 11, 2013
  7. brian m. carlsonOct 12, 2013
  8. brian m. carlsonOct 18, 2013
  9. Junio C HamanoOct 22, 2013
  10. Jonathan NiederOct 22, 2013
  11. Jonathan NiederOct 23, 2013
  12. brian m. carlsonOct 23, 2013
  13. Shawn PearceOct 23, 2013
  14. brian m. carlsonOct 23, 2013
  15. Jeff KingOct 25, 2013
  16. brian m. carlsonOct 25, 2013
  17. Junio C HamanoOct 23, 2013
  18. brian m. carlsonOct 23, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.