Re: [PATCH v2 2/2] Update documentation for http.continue option

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Oct 18, 2013, 22:15 UTC
Message-ID: <20131018221535.GM865149@vauxhall.crustytoothpaste.net>
In-Reply-To: <20131012002639.GE79408@vauxhall.crustytoothpaste.net>

On Sat, Oct 12, 2013 at 12:26:39AM +0000, brian m. carlson wrote:

Show 15 quoted lines

> On Fri, Oct 11, 2013 at 04:50:52PM -0700, Jonathan Nieder wrote:
> > Perhaps this should be conditional on the authentication method used,
> > so affected people could still contact broken servers without having
> > different configuration per server and without having to wait a second
> > for the timeout.
> 
> curl determines what method, but I guess it's safe to assume that the
> authentication method used for the probe will be the same as the one
> used for the final connection.  Unfortunately, all curl will tell us is
> what was offered, not what it would have chosen, so if GSSAPI and
> something non-Basic are both offered, we'd have to make a guess.  (curl
> will always prefer non-Basic to Basic for the obvious reasons.)
> 
> If you can argue for some sane semantics in what we should do in that
> case, I'll reroll with that fix and a clearer wording for the docs.

Reading Jonathan Nieder's responses to the first patch, it looks like he was going to apply it, but I haven't seen it make its way into next or pu. Junio, do you want a reroll, and if so, do you want certain semantics for autodetecting this case, or are you just looking for documentation fixes?

-- 
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187