git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/6] config.c: Fix a sparse warning

From
Jeff King <peff@peff.net>
Date
Oct 7, 2013, 11:31 UTC
Message-ID
<20131007113135.GB5792@sigill.intra.peff.net>
In-Reply-To
<5251CC9D.9040309@ramsay1.demon.co.uk>
On Sun, Oct 06, 2013 at 09:48:29PM +0100, Ramsay Jones wrote:
> Sparse issues an "'git_parse_unsigned' was not declared. Should it
> be static?" warning. In order to suppress this warning, since this
> symbol only requires file scope, we simply add the static modifier
> to its declaration.

Thanks. This one is my fault. Commit 7192777 refactors git_parse_ulong, which is public, into a more generic function. But since we kept the git_parse_ulong wrapper, only that part needs to be public; nobody outside the file calls the lower-level git_parse_unsigned.

-Peff
Previous: Ramsay Jones
Message 2 of 2 in “config.c: Fix a sparse warning”
  1. 1/6 config.c: Fix a sparse warningRamsay Jones, Oct 6, 2013
  2. Jeff KingOct 7, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.