From: Jeff King <peff@peff.net>
Date: Mon, 07 Oct 2013 11:31:36 GMT
Subject: Re: [PATCH 1/6] config.c: Fix a sparse warning
Message-ID: <20131007113135.GB5792@sigill.intra.peff.net>
In-Reply-To: <5251CC9D.9040309@ramsay1.demon.co.uk>

On Sun, Oct 06, 2013 at 09:48:29PM +0100, Ramsay Jones wrote:

> Sparse issues an "'git_parse_unsigned' was not declared. Should it
> be static?" warning. In order to suppress this warning, since this
> symbol only requires file scope, we simply add the static modifier
> to its declaration.

Thanks. This one is my fault. Commit 7192777 refactors git_parse_ulong,
which is public, into a more generic function. But since we kept the
git_parse_ulong wrapper, only that part needs to be public; nobody
outside the file calls the lower-level git_parse_unsigned.

-Peff