threads / patch / 35072

patch, 6 partsconfig.c: Fix a sparse warning

Subject: [PATCH 1/6] config.c: Fix a sparse warning

## tl;dr

2 messages between Oct 6, 2013 and Oct 7, 2013. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Ramsay Jones· Oct 6, 2013, 20:48 UTC · lore

Sparse issues an "'git_parse_unsigned' was not declared. Should it be static?" warning. In order to suppress this warning, since this symbol only requires file scope, we simply add the static modifier to its declaration.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
 config.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to config.c +1 −1

diff --git a/config.c b/config.c
index 6588cf5..e1d66a1 100644
--- a/config.c
+++ b/config.c
@@ -498,7 +498,7 @@ static int git_parse_signed(const char *value, intmax_t *ret, intmax_t max)
 	return 0;
 }
 
-int git_parse_unsigned(const char *value, uintmax_t *ret, uintmax_t max)
+static int git_parse_unsigned(const char *value, uintmax_t *ret, uintmax_t max)
 {
 	if (value && *value) {
 		char *end;

-- 
1.8.4

Jeff King· Oct 7, 2013, 11:31 UTC · re: Ramsay Jones · lore

Re: [PATCH 1/6] config.c: Fix a sparse warning

On Sun, Oct 06, 2013 at 09:48:29PM +0100, Ramsay Jones wrote:

> Sparse issues an "'git_parse_unsigned' was not declared. Should it
> be static?" warning. In order to suppress this warning, since this
> symbol only requires file scope, we simply add the static modifier
> to its declaration.

Thanks. This one is my fault. Commit 7192777 refactors git_parse_ulong, which is public, into a more generic function. But since we kept the git_parse_ulong wrapper, only that part needs to be public; nobody outside the file calls the lower-level git_parse_unsigned.

-Peff