git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] urlmatch.c: recompute ptr after append_normalized_escapes

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Sep 12, 2013, 22:05 UTC
Message-ID
<20130912220505.GM4326@google.com>
In-Reply-To
<85CEBFAA-8905-46EC-88C5-5DDE629B73F9@gmail.com>
Kyle J. McKay wrote:
> The longer comment looks good to me.  If you think the code will be safe from
> simplification patches without a comment, that works for me too.

I think if we can't trust reviewers to catch this kind of thing, we're in trouble (i.e., moving too fast). :)

So FWIW my instinct is to leave the comment out, since I actually find it more readable that way (otherwise I would wonder, "Why am I being told that a strbuf's buffer has a nonconstant address? Do some other strbufs have a constant address or something?")

Thanks, Jonathan

Previous: Kyle J. McKayNext: Junio C Hamano
Message 7 of 8 in “urlmatch: append_normalized_escapes can reallocate norm.buf”
  1. urlmatch: append_normalized_escapes can reallocate norm.bufThomas Rast, Sep 12, 2013
  2. urlmatch.c: recompute ptr after append_normalized_escapesKyle J. McKay, Sep 12, 2013
  3. Thomas RastSep 12, 2013
  4. Junio C HamanoSep 12, 2013
  5. Junio C HamanoSep 12, 2013
  6. Kyle J. McKaySep 12, 2013
  7. Jonathan NiederSep 12, 2013
  8. Junio C HamanoSep 12, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.