git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] urlmatch.c: recompute ptr after append_normalized_escapes

From
Thomas Rast <trast@inf.ethz.ch>
Date
Sep 12, 2013, 15:25 UTC
Message-ID
<87a9jidpv5.fsf@linux-k42r.v.cablecom.net>
In-Reply-To
<c8915eaaf877abe0e69864ffdc6c50f@f74d39fa044aa309eaea14b9f57fe79>
"Kyle J. McKay" <mackyle@gmail.com> writes:
> Also some nits.  The patch description should be imperative mood
> (cf. Documentation/SubmittingPatches).

Heh. Serves me right to go away for a while and get SubmittingPatches cited at me on return ;-)

Thanks for the updated patch. I agree with the changes. I particularly like the better variable name.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch
Previous: Kyle J. McKayNext: Junio C Hamano
Message 3 of 8 in “urlmatch: append_normalized_escapes can reallocate norm.buf”
  1. urlmatch: append_normalized_escapes can reallocate norm.bufThomas Rast, Sep 12, 2013
  2. urlmatch.c: recompute ptr after append_normalized_escapesKyle J. McKay, Sep 12, 2013
  3. Thomas RastSep 12, 2013
  4. Junio C HamanoSep 12, 2013
  5. Junio C HamanoSep 12, 2013
  6. Kyle J. McKaySep 12, 2013
  7. Jonathan NiederSep 12, 2013
  8. Junio C HamanoSep 12, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.