From: Jonathan Nieder <jrnieder@gmail.com>
Date: Thu, 12 Sep 2013 22:05:05 GMT
Subject: Re: [PATCH v2] urlmatch.c: recompute ptr after append_normalized_escapes
Message-ID: <20130912220505.GM4326@google.com>
In-Reply-To: <85CEBFAA-8905-46EC-88C5-5DDE629B73F9@gmail.com>

Kyle J. McKay wrote:

> The longer comment looks good to me.  If you think the code will be safe from
> simplification patches without a comment, that works for me too.

I think if we can't trust reviewers to catch this kind of thing, we're
in trouble (i.e., moving too fast). :)

So FWIW my instinct is to leave the comment out, since I actually find
it more readable that way (otherwise I would wonder, "Why am I being
told that a strbuf's buffer has a nonconstant address?  Do some other
strbufs have a constant address or something?")

Thanks,
Jonathan