git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 03/11] t6050-replace: test that objects are of the same type

From
Christian Couder <chriscool@tuxfamily.org>
Date
Sep 5, 2013, 19:13 UTC
Message-ID
<20130905.211349.627536889681040925.chriscool@tuxfamily.org>
In-Reply-To
<xmqqa9jsmich.fsf@gitster.dls.corp.google.com>
From: Junio C Hamano <gitster@pobox.com>
Show 11 quoted lines
>
> Christian Couder <chriscool@tuxfamily.org> writes:
>>  
>> +test_expect_success 'replaced and replacement objects must be of the same type' '
>> +	test_must_fail git replace mytag $HASH1 2>err &&
>> +	grep "mytag. points to a replaced object of type .tag" err &&
>> +	grep "$HASH1. points to a replacement object of type .commit" err &&
> 
> Hmm, would these messages ever get translated?  I think it is
> sufficient to make sure that the proposed replacement fails for
> these cases.
Ok, I will get rid of the grep statements.

Thanks, Christian.

Previous: Junio C HamanoNext: Christian Couder
Message 6 of 20 in “Check replacement object type and minor updates”
  1. 00/11 Check replacement object type and minor updatesChristian Couder, Sep 3, 2013
  2. 01/11 replace: forbid replacing an object with one of a different typeChristian Couder, Sep 3, 2013
  3. 02/11 Documentation/replace: state that objects must be of the same typeChristian Couder, Sep 3, 2013
  4. 03/11 t6050-replace: test that objects are of the same typeChristian Couder, Sep 3, 2013
  5. Junio C HamanoSep 4, 2013
  6. Christian CouderSep 5, 2013
  7. 04/11 t6050-replace: add test to clean up all the replace refsChristian Couder, Sep 3, 2013
  8. 05/11 Documentation/replace: add Creating Replacement Objects sectionChristian Couder, Sep 3, 2013
  9. 06/11 replace: bypass the type check if -f option is usedChristian Couder, Sep 3, 2013
  10. Junio C HamanoSep 4, 2013
  11. Christian CouderSep 5, 2013
  12. 07/11 Documentation/replace: tell that -f option bypasses the type checkChristian Couder, Sep 3, 2013
  13. Junio C HamanoSep 4, 2013
  14. Junio C HamanoSep 4, 2013
  15. 08/11 t6050-replace: check that -f option bypasses the type checkChristian Couder, Sep 3, 2013
  16. 09/11 replace: allow long option namesChristian Couder, Sep 3, 2013
  17. 10/11 Documentation/replace: list long option namesChristian Couder, Sep 3, 2013
  18. Junio C HamanoSep 4, 2013
  19. Christian CouderSep 5, 2013
  20. 11/11 t6050-replace: use some long option namesChristian Couder, Sep 3, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.