From: Christian Couder <chriscool@tuxfamily.org>
Date: Thu, 05 Sep 2013 19:13:49 GMT
Subject: Re: [PATCH v4 03/11] t6050-replace: test that objects are of the same type
Message-ID: <20130905.211349.627536889681040925.chriscool@tuxfamily.org>
In-Reply-To: <xmqqa9jsmich.fsf@gitster.dls.corp.google.com>

From: Junio C Hamano <gitster@pobox.com>
>
> Christian Couder <chriscool@tuxfamily.org> writes:
>>  
>> +test_expect_success 'replaced and replacement objects must be of the same type' '
>> +	test_must_fail git replace mytag $HASH1 2>err &&
>> +	grep "mytag. points to a replaced object of type .tag" err &&
>> +	grep "$HASH1. points to a replacement object of type .commit" err &&
> 
> Hmm, would these messages ever get translated?  I think it is
> sufficient to make sure that the proposed replacement fails for
> these cases.

Ok, I will get rid of the grep statements.

Thanks,
Christian.