From: Jeff King <peff@peff.net>
Date: Tue, 14 May 2013 02:35:51 GMT
Subject: Re: Re: [PATCH v4 3/5] config: make parsing stack struct independent from actual data source
Message-ID: <20130514023551.GB23146@sigill.intra.peff.net>
In-Reply-To: <20130513140435.GC3561@book-mint>

On Mon, May 13, 2013 at 04:04:35PM +0200, Heiko Voigt wrote:

> > > -static int do_config_from(struct config_file *top, config_fn_t fn, void *data)
> > > +static int do_config_from_source(struct config_source *top, config_fn_t fn, void *data)
> [...]
> I thought I recalled that Jeff asked me to change the name but I can
> not find the email, so maybe its just my wrong memory. I am happy to
> drop the rename here, if thats what you meant.

I think you are thinking of:

  http://thread.gmane.org/gmane.comp.version-control.git/217018/focus=217170

where I criticize the name. But I think the comment you added makes its
purpose much more clear, so the name is less important (and for the
record, I think "do_config" or "config_source_parse" would be fine,
too).

-Peff