git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] contrib/test-hg*.sh: Do not use PYTHON_PATH

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Apr 17, 2013, 15:53 UTC
Message-ID
<20130417155326.GB3499@elie.Belkin>
In-Reply-To
<201304171610.49384.tboegi@web.de>
Hi,
Torsten Bögershausen wrote:
> Git respects PYTHON_PATH, hg does not.

Probably more relevant is that contrib/remote-helpers/git-remote-hg has a shebang line of "#!/usr/bin/env python" and hence does not respect PYTHON_PATH.

> Use python instead of $PYTHON_PATH to check for installed modules.
Makes sense to me.
> While at it, split exportX=Y into 2 lines

Would you mind splitting this change (which also looks good) into a separate patch? It makes life debugging, cherry-picking, reading, reverting when needed, and so on easier.

Hope that helps, Jonathan

Previous: Torsten BögershausenNext: Junio C Hamano
Message 2 of 5 in “contrib/test-hg*.sh: Do not use PYTHON_PATH”
  1. contrib/test-hg*.sh: Do not use PYTHON_PATHTorsten Bögershausen, Apr 17, 2013
  2. Jonathan NiederApr 17, 2013
  3. Junio C HamanoApr 17, 2013
  4. Felipe ContrerasApr 17, 2013
  5. Felipe ContrerasApr 17, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.