From: Jonathan Nieder <jrnieder@gmail.com>
Date: Wed, 17 Apr 2013 15:53:26 GMT
Subject: Re: [PATCH] contrib/test-hg*.sh: Do not use PYTHON_PATH
Message-ID: <20130417155326.GB3499@elie.Belkin>
In-Reply-To: <201304171610.49384.tboegi@web.de>

Hi,

Torsten Bögershausen wrote:

> Git respects PYTHON_PATH, hg does not.

Probably more relevant is that contrib/remote-helpers/git-remote-hg
has a shebang line of "#!/usr/bin/env python" and hence does not
respect PYTHON_PATH.

> Use python instead of $PYTHON_PATH to check for installed modules.

Makes sense to me.

> While at it, split exportX=Y into 2 lines

Would you mind splitting this change (which also looks good) into a
separate patch?  It makes life debugging, cherry-picking, reading,
reverting when needed, and so on easier.

Hope that helps,
Jonathan