git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] contrib/test-hg*.sh: Do not use PYTHON_PATH

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Apr 17, 2013, 19:17 UTC
Message-ID
<CAMP44s1i5Pw5-Cbn3v_fGPLScjcs3HbUNkSpCgCngsTNnb1DJg@mail.gmail.com>
In-Reply-To
<CAMP44s2RTKLO3nhBJcm_KAwq9iHt8ZSXeFuYksYv_JebK-eqrg@mail.gmail.com>

On Wed, Apr 17, 2013 at 1:36 PM, Felipe Contreras <felipe.contreras@gmail.com> wrote:

Show 17 quoted lines
> On Wed, Apr 17, 2013 at 9:10 AM, Torsten Bögershausen <tboegi@web.de> wrote:
>> The test cases in contrib/remote-helpers use mercurial and python.
>> Before the tests are run, we check if python can import
>> "mercurial" and "hggit".
>> To run this check, python pointed out by PYTHON_PATH is used.
>> This may not work when different python binaries exist,
>> and PYTHON_PATH is not set:
>>  Makefile sets it to the default /usr/bin/python
>>  The PATH may point out e.g. /sw/bin/python.
>> When /sw/bin/python has the mercurial module installed,
>> but /usr/bin/python has not, the test will not be run.
>>
>> Git respects PYTHON_PATH, hg does not.
>> Use python instead of $PYTHON_PATH to check for installed modules.
>
> And this would fail if the distribution doesn't have a 'python'
> binary, and instead has python2, python3, etc.

Also, it would fail if mercurial is installed for python2, and python is really python3.

-- 
Felipe Contreras
Previous: Felipe Contreras
Message 5 of 5 in “contrib/test-hg*.sh: Do not use PYTHON_PATH”
  1. contrib/test-hg*.sh: Do not use PYTHON_PATHTorsten Bögershausen, Apr 17, 2013
  2. Jonathan NiederApr 17, 2013
  3. Junio C HamanoApr 17, 2013
  4. Felipe ContrerasApr 17, 2013
  5. Felipe ContrerasApr 17, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.