git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 5/5] string_list_add_refs_from_colon_sep(): use string_list_split()

From
Jeff King <peff@peff.net>
Date
Nov 4, 2012, 11:57 UTC
Message-ID
<20121104115750.GC336@sigill.intra.peff.net>
In-Reply-To
<1352012830-13591-6-git-send-email-mhagger@alum.mit.edu>
On Sun, Nov 04, 2012 at 08:07:10AM +0100, Michael Haggerty wrote:
> It makes for simpler code than strbuf_split().
Agreed.

I wonder how useful the strbuf_split functions really are. Callers might care about splitting content in a strbuf, but in general, getting a list of strbufs out is just a hassle, and a string_list makes more sense.

It's probably not worth spending time converting them unless we happen to be working in the area, though.

-Peff
Previous: Michael HaggertyNext: Johan Herland
Message 7 of 8 in “Use string_lists when processing notes”
  1. 0/5 Use string_lists when processing notesMichael Haggerty, Nov 4, 2012
  2. 1/5 string_list: add a function string_list_remove_empty_items()Michael Haggerty, Nov 4, 2012
  3. 2/5 Initialize sort_uniq_list using named constantMichael Haggerty, Nov 4, 2012
  4. 3/5 combine_notes_cat_sort_uniq(): sort and dedup lines all at onceMichael Haggerty, Nov 4, 2012
  5. 4/5 notes: fix handling of colon-separated valuesMichael Haggerty, Nov 4, 2012
  6. 5/5 string_list_add_refs_from_colon_sep(): use string_list_split()Michael Haggerty, Nov 4, 2012
  7. Jeff KingNov 4, 2012
  8. Johan HerlandNov 6, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.