git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/5] Initialize sort_uniq_list using named constant

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Nov 4, 2012, 07:07 UTC
Message-ID
<1352012830-13591-3-git-send-email-mhagger@alum.mit.edu>
In-Reply-To
<1352012830-13591-1-git-send-email-mhagger@alum.mit.edu>
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
 notes.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/notes.c b/notes.c
index bc454e1..8652f8f 100644
--- a/notes.c
+++ b/notes.c
@@ -901,7 +901,7 @@ static int string_list_join_lines_helper(struct string_list_item *item,
 int combine_notes_cat_sort_uniq(unsigned char *cur_sha1,
 		const unsigned char *new_sha1)
 {
-	struct string_list sort_uniq_list = { NULL, 0, 0, 1 };
+	struct string_list sort_uniq_list = STRING_LIST_INIT_DUP;
 	struct strbuf buf = STRBUF_INIT;
 	int ret = 1;
 
-- 
1.8.0
Previous: Michael HaggertyNext: Michael Haggerty
Message 3 of 8 in “Use string_lists when processing notes”
  1. 0/5 Use string_lists when processing notesMichael Haggerty, Nov 4, 2012
  2. 1/5 string_list: add a function string_list_remove_empty_items()Michael Haggerty, Nov 4, 2012
  3. 2/5 Initialize sort_uniq_list using named constantMichael Haggerty, Nov 4, 2012
  4. 3/5 combine_notes_cat_sort_uniq(): sort and dedup lines all at onceMichael Haggerty, Nov 4, 2012
  5. 4/5 notes: fix handling of colon-separated valuesMichael Haggerty, Nov 4, 2012
  6. 5/5 string_list_add_refs_from_colon_sep(): use string_list_split()Michael Haggerty, Nov 4, 2012
  7. Jeff KingNov 4, 2012
  8. Johan HerlandNov 6, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.