From: Jeff King <peff@peff.net>
Date: Sun, 04 Nov 2012 11:57:50 GMT
Subject: Re: [PATCH 5/5] string_list_add_refs_from_colon_sep(): use string_list_split()
Message-ID: <20121104115750.GC336@sigill.intra.peff.net>
In-Reply-To: <1352012830-13591-6-git-send-email-mhagger@alum.mit.edu>

On Sun, Nov 04, 2012 at 08:07:10AM +0100, Michael Haggerty wrote:

> It makes for simpler code than strbuf_split().

Agreed.

I wonder how useful the strbuf_split functions really are. Callers might
care about splitting content in a strbuf, but in general, getting a list
of strbufs out is just a hassle, and a string_list makes more sense.

It's probably not worth spending time converting them unless we happen
to be working in the area, though.

-Peff