git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/4] Simplify and document strbuf_split() functions

From
Jeff King <peff@peff.net>
Date
Nov 4, 2012, 11:50 UTC
Message-ID
<20121104115043.GB336@sigill.intra.peff.net>
In-Reply-To
<1352011614-29334-1-git-send-email-mhagger@alum.mit.edu>
On Sun, Nov 04, 2012 at 07:46:50AM +0100, Michael Haggerty wrote:
> The strbuf_split() family of functions was completely undocumented.
> Add documentation and also simplify the definition of
> strbuf_split_buf().

Thanks. Looks good overall, even with the comments I raised for patch 1 (I think it is not a big deal, and even if it does become a big deal, the right fix is probably to make alloc_nr smarter about early growth).

-Peff
Previous: Michael Haggerty
Message 9 of 9 in “Simplify and document strbuf_split() functions”
  1. 0/4 Simplify and document strbuf_split() functionsMichael Haggerty, Nov 4, 2012
  2. 1/4 strbuf_split_buf(): use ALLOC_GROW()Michael Haggerty, Nov 4, 2012
  3. Jeff KingNov 4, 2012
  4. Michael HaggertyNov 6, 2012
  5. Jeff KingNov 8, 2012
  6. 2/4 strbuf_split_buf(): simplify iterationMichael Haggerty, Nov 4, 2012
  7. 3/4 strbuf_split*(): rename "delim" parameter to "terminator"Michael Haggerty, Nov 4, 2012
  8. 4/4 strbuf_split*(): document functionsMichael Haggerty, Nov 4, 2012
  9. Jeff KingNov 4, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.