From: Jeff King Date: Sun, 04 Nov 2012 11:50:44 GMT Subject: Re: [PATCH 0/4] Simplify and document strbuf_split() functions Message-ID: <20121104115043.GB336@sigill.intra.peff.net> In-Reply-To: <1352011614-29334-1-git-send-email-mhagger@alum.mit.edu> On Sun, Nov 04, 2012 at 07:46:50AM +0100, Michael Haggerty wrote: > The strbuf_split() family of functions was completely undocumented. > Add documentation and also simplify the definition of > strbuf_split_buf(). Thanks. Looks good overall, even with the comments I raised for patch 1 (I think it is not a big deal, and even if it does become a big deal, the right fix is probably to make alloc_nr smarter about early growth). -Peff