git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fix 'make test' for HP NonStop

From
Jeff King <peff@peff.net>
Date
Oct 25, 2012, 09:58 UTC
Message-ID
<20121025095826.GM8390@sigill.intra.peff.net>
In-Reply-To
<001e01cdb061$c25f6380$471e2a80$@schmitz-digital.de>
On Mon, Oct 22, 2012 at 04:30:17PM +0200, Joachim Schmitz wrote:
Show 5 quoted lines
> +	# for 'make test'
> +	# some test don't work with /bin/diff, some fail with /bin/tar
> +	# some need bash, and some need ${prefix}/bin in PATH first
> +	SHELL_PATH=${prefix}/bin/bash
> +	SANE_TOOL_PATH=${prefix}/bin

This feels a little too specific to go in our Makefile. Do we have any reason to think that where you are installing git is going to be the same place you have bash and other sane tools? Wouldn't this mean that things work when you run "make" but mysteriously break when you run "make prefix=/my/local/install/of/git"?

-Peff
Previous: Joachim SchmitzNext: Joachim Schmitz
Message 2 of 7 in “fix 'make test' for HP NonStop”
  1. fix 'make test' for HP NonStopJoachim Schmitz, Oct 22, 2012
  2. Jeff KingOct 25, 2012
  3. Joachim SchmitzOct 25, 2012
  4. Jeff KingOct 25, 2012
  5. Joachim SchmitzOct 25, 2012
  6. Jeff KingOct 25, 2012
  7. Joachim SchmitzOct 25, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.