From: Jeff King <peff@peff.net>
Date: Thu, 25 Oct 2012 09:58:26 GMT
Subject: Re: [PATCH] fix 'make test' for HP NonStop
Message-ID: <20121025095826.GM8390@sigill.intra.peff.net>
In-Reply-To: <001e01cdb061$c25f6380$471e2a80$@schmitz-digital.de>

On Mon, Oct 22, 2012 at 04:30:17PM +0200, Joachim Schmitz wrote:

> +	# for 'make test'
> +	# some test don't work with /bin/diff, some fail with /bin/tar
> +	# some need bash, and some need ${prefix}/bin in PATH first
> +	SHELL_PATH=${prefix}/bin/bash
> +	SANE_TOOL_PATH=${prefix}/bin

This feels a little too specific to go in our Makefile. Do we have any
reason to think that where you are installing git is going to be the
same place you have bash and other sane tools? Wouldn't this mean that
things work when you run "make" but mysteriously break when you run
"make prefix=/my/local/install/of/git"?

-Peff