Re: [PATCH] fix 'make test' for HP NonStop

From: Jeff King <peff@peff.net>
Date: Oct 25, 2012, 10:49 UTC
Message-ID: <20121025104900.GA6363@sigill.intra.peff.net>
In-Reply-To: <002e01cdb29a$893593f0$9ba0bbd0$@schmitz-digital.de>

On Thu, Oct 25, 2012 at 12:21:44PM +0200, Joachim Schmitz wrote:

Show 13 quoted lines

> > > +	# for 'make test'
> > > +	# some test don't work with /bin/diff, some fail with /bin/tar
> > > +	# some need bash, and some need ${prefix}/bin in PATH first
> > > +	SHELL_PATH=${prefix}/bin/bash
> > > +	SANE_TOOL_PATH=${prefix}/bin
> > 
> > This feels a little too specific to go in our Makefile. Do we have any
> > reason to think that where you are installing git is going to be the
> > same place you have bash and other sane tools? Wouldn't this mean that
> > things work when you run "make" but mysteriously break when you run
> > "make prefix=/my/local/install/of/git"?
> 
> Well, "make" won't break (I think), but "make test" very well might.

Sure.

> Well, so far all OpenSource packages ported to HP NonStop (at least
> the ones on ituglib.connect-community.org) use prefix=/usr/local and
> there is no intention to change that.

But then I would think using /usr/local would be the sane thing to put there, if that is the closest to "standard" for your platform.

If there is not a standard, then I think we are better off leaving it blank and letting people do the right thing for their system (including packagers who are building for other people).

-Peff