git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] The Makefile.PL will now find .pm files itself.

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Jul 25, 2012, 21:31 UTC
Message-ID
<20120725213112.GG4732@burratino>
In-Reply-To
<20120725211143.GA5455@burratino>
Jonathan Nieder wrote:
> Michael G. Schwern wrote:
Show 10 quoted lines
>> --- a/perl/Makefile.PL
>> +++ b/perl/Makefile.PL
>> @@ -2,6 +2,10 @@ use strict;
>>  use warnings;
>>  use ExtUtils::MakeMaker;
>>  use Getopt::Long;
>> +use File::Find;
>> +
>> +# Don't forget to update the perl/Makefile, too.
>> +# Don't forget to test with NO_PERL_MAKEMAKER=YesPlease
[...]
> Who are these comments in perl/Makefile.PL addressed to?  Why would
> such a person be looking at perl/Makefile.PL?  Sorry to sound like a
> broken record, but I don't think these questions were answered yet.

To maybe answer my own question: are these comments addressed to people making other changes to perl/Makefile.PL, rather than people adding new modules?

That could make sense --- it would just be a change in purpose from the original comments. It also means there's no reminder when adding new modules to list them in perl/Makefile any more, but that's probably inevitable as long as we don't have a perl coding style document.

Hoping that clarifies, Jonathan

Previous: Jonathan NiederNext: Michael G Schwern
Message 6 of 16 in “Teach Makefile.PL to find .pm files on its own”
  1. Michael G. SchwernJul 25, 2012
  2. 1/3 Quiet warning if Makefile.PL is run with -w and no --localedirMichael G. Schwern, Jul 25, 2012
  3. 2/3 Don't lose Error.pm if $@ gets clobbered.Michael G. Schwern, Jul 25, 2012
  4. 3/3 The Makefile.PL will now find .pm files itself.Michael G. Schwern, Jul 25, 2012
  5. Jonathan NiederJul 25, 2012
  6. Jonathan NiederJul 25, 2012
  7. Michael G SchwernJul 25, 2012
  8. Jonathan NiederJul 25, 2012
  9. Junio C HamanoJul 25, 2012
  10. Michael G SchwernJul 25, 2012
  11. Junio C HamanoJul 25, 2012
  12. Michael G SchwernJul 25, 2012
  13. Junio C HamanoJul 25, 2012
  14. Michael G SchwernJul 25, 2012
  15. Junio C HamanoJul 25, 2012
  16. Eric WongJul 25, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.