Re: [PATCH 3/3] The Makefile.PL will now find .pm files itself.

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jul 25, 2012, 21:11 UTC
Message-ID: <20120725211143.GA5455@burratino>
In-Reply-To: <1343186471-1024-4-git-send-email-schwern@pobox.com>

Hi,

Michael G. Schwern wrote:

> It is no longer necessary to manually add new .pm files to the
> Makefile.PL.  This makes it easier to add modules.

Thanks!  Sorry I missed this.

[...]

Show 10 quoted lines

> --- a/perl/Makefile.PL
> +++ b/perl/Makefile.PL
> @@ -2,6 +2,10 @@ use strict;
>  use warnings;
>  use ExtUtils::MakeMaker;
>  use Getopt::Long;
> +use File::Find;
> +
> +# Don't forget to update the perl/Makefile, too.
> +# Don't forget to test with NO_PERL_MAKEMAKER=YesPlease

In a previous apartment I lived in, there was a note taped to the lightswitch reminding us to turn off the heat, take keys with us, and lock the door. The note was useful because by force of habit we would be turning off the light, and as a result see the note, on the way out.

Who are these comments in perl/Makefile.PL addressed to? Why would such a person be looking at perl/Makefile.PL? Sorry to sound like a broken record, but I don't think these questions were answered yet.

How about this patch for squashing in, which would avoid the question and save me from having to worry that my words are going to stay in this file after the no-makemaker option no longer exists because nobody looks at them here?

diff --git i/perl/Makefile.PL w/perl/Makefile.PL
index 3d88a6b9..377fd042 100644
--- i/perl/Makefile.PL
+++ w/perl/Makefile.PL
@@ -4,9 +4,6 @@ use ExtUtils::MakeMaker;
 use Getopt::Long;
 use File::Find;
 
-# Don't forget to update the perl/Makefile, too.
-# Don't forget to test with NO_PERL_MAKEMAKER=YesPlease
-
 # Sanity: die at first unknown option
 Getopt::Long::Configure qw/ pass_through /;