git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/3] Quiet warning if Makefile.PL is run with -w and no --localedir

From
Michael G. Schwern <schwern@pobox.com>
Date
Jul 25, 2012, 03:21 UTC
Message-ID
<1343186471-1024-2-git-send-email-schwern@pobox.com>
In-Reply-To
<1343186471-1024-1-git-send-email-schwern@pobox.com>
From: "Michael G. Schwern" <schwern@pobox.com>
Usually it isn't, but its nice if it can be run with warnings on.
Signed-off-by: Michael G Schwern <schwern@pobox.com>
---
 perl/Makefile.PL | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/perl/Makefile.PL b/perl/Makefile.PL
index b54b04a..87e1f62 100644
--- a/perl/Makefile.PL
+++ b/perl/Makefile.PL
@@ -6,7 +6,8 @@ use Getopt::Long;
 # Sanity: die at first unknown option
 Getopt::Long::Configure qw/ pass_through /;
 
-GetOptions("localedir=s" => \my $localedir);
+my $localedir = '';
+GetOptions("localedir=s" => \$localedir);
 
 sub MY::postamble {
 	return <<'MAKE_FRAG';
-- 
1.7.11.1
Previous: Michael G. SchwernNext: Michael G. Schwern
Message 2 of 16 in “Teach Makefile.PL to find .pm files on its own”
  1. Michael G. SchwernJul 25, 2012
  2. 1/3 Quiet warning if Makefile.PL is run with -w and no --localedirMichael G. Schwern, Jul 25, 2012
  3. 2/3 Don't lose Error.pm if $@ gets clobbered.Michael G. Schwern, Jul 25, 2012
  4. 3/3 The Makefile.PL will now find .pm files itself.Michael G. Schwern, Jul 25, 2012
  5. Jonathan NiederJul 25, 2012
  6. Jonathan NiederJul 25, 2012
  7. Michael G SchwernJul 25, 2012
  8. Jonathan NiederJul 25, 2012
  9. Junio C HamanoJul 25, 2012
  10. Michael G SchwernJul 25, 2012
  11. Junio C HamanoJul 25, 2012
  12. Michael G SchwernJul 25, 2012
  13. Junio C HamanoJul 25, 2012
  14. Michael G SchwernJul 25, 2012
  15. Junio C HamanoJul 25, 2012
  16. Eric WongJul 25, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.