Re: [PATCH v2 4/4] completion: improve 'git --exec-path' completion

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Apr 13, 2012, 06:08 UTC
Message-ID: <20120413060845.GA15610@burratino>
In-Reply-To: <1334274603-3277-5-git-send-email-felipe.contreras@gmail.com>

Felipe Contreras wrote:

> All other options that accept an argument are completed this way, plus,
> the '--foo bar' format doesn't seem to work correctly at the moment.

[...]

Show 9 quoted lines

> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -2638,7 +2638,7 @@ _git ()
>  			--git-dir=
>  			--bare
>  			--version
> -			--exec-path
> +			--exec-path=
>  			--html-path

Thanks.

"git --exec-path" means to print the name of the directory where git stores its subcommands and other helpers. I have no thoughts either way about whether a user typing

	git --exec-p<TAB>

is more likely to be asking for the current exec-path or intending to override it.

Hope that helps, Jonathan