git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 1/4] completion: simplify __gitcomp_1

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Apr 12, 2012, 23:50 UTC
Message-ID
<1334274603-3277-2-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1334274603-3277-1-git-send-email-felipe.contreras@gmail.com>
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 contrib/completion/git-completion.bash |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 31f714d..13be9a7 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -307,13 +307,13 @@ __git_ps1 ()
 # __gitcomp_1 requires 2 arguments
 __gitcomp_1 ()
 {
-	local c IFS=' '$'\t'$'\n'
+	local c s IFS=' '$'\t'$'\n'
 	for c in $1; do
 		case "$c$2" in
-		--*=*) printf %s$'\n' "$c$2" ;;
-		*.)    printf %s$'\n' "$c$2" ;;
-		*)     printf %s$'\n' "$c$2 " ;;
+		--*=* | *.) s="" ;;
+		*)          s=" " ;;
 		esac
+		echo "$c$2$s"
 	done
 }
 
-- 
1.7.10.1.g1f19b8.dirty
Previous: Felipe ContrerasNext: Felipe Contreras
Message 2 of 12 in “completion: trivial cleanups and fixes”
  1. 0/4 completion: trivial cleanups and fixesFelipe Contreras, Apr 12, 2012
  2. 1/4 completion: simplify __gitcomp_1Felipe Contreras, Apr 12, 2012
  3. 2/4 completion: trivial simplificationFelipe Contreras, Apr 12, 2012
  4. 3/4 completion: add missing general optionsFelipe Contreras, Apr 12, 2012
  5. 4/4 completion: improve 'git --exec-path' completionFelipe Contreras, Apr 12, 2012
  6. Jonathan NiederApr 13, 2012
  7. Jonathan NiederApr 13, 2012
  8. Jonathan NiederApr 13, 2012
  9. Felipe ContrerasApr 13, 2012
  10. Jonathan NiederApr 13, 2012
  11. Felipe ContrerasApr 13, 2012
  12. Andreas SchwabApr 14, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.