git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 4/4] completion: improve 'git --exec-path' completion

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Apr 12, 2012, 23:50 UTC
Message-ID
<1334274603-3277-5-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1334274603-3277-1-git-send-email-felipe.contreras@gmail.com>

All other options that accept an argument are completed this way, plus, the '--foo bar' format doesn't seem to work correctly at the moment.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 contrib/completion/git-completion.bash |    2 +-
 t/t9902-completion.sh                  |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 6a8cf9f..efed24a 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -2638,7 +2638,7 @@ _git ()
 			--git-dir=
 			--bare
 			--version
-			--exec-path
+			--exec-path=
 			--html-path
 			--info-path
 			--work-tree=
diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh
index f2075af..fd2ed3e 100755
--- a/t/t9902-completion.sh
+++ b/t/t9902-completion.sh
@@ -90,7 +90,7 @@ test_expect_success 'double dash "git" itself' '
 	--git-dir=
 	--bare Z
 	--version Z
-	--exec-path Z
+	--exec-path=
 	--html-path Z
 	--info-path Z
 	--work-tree=
@@ -119,7 +119,7 @@ test_expect_success 'double dash "git checkout"' '
 test_expect_success 'general options' '
 	test_completion "git --ver" "--version " &&
 	test_completion "git --hel" "--help " &&
-	test_completion "git --exe" "--exec-path " &&
+	test_completion "git --exe" "--exec-path=" &&
 	test_completion "git --htm" "--html-path " &&
 	test_completion "git --pag" "--paginate " &&
 	test_completion "git --no-p" "--no-pager " &&
-- 
1.7.10.1.g1f19b8.dirty
Previous: Felipe ContrerasNext: Jonathan Nieder
Message 5 of 12 in “completion: trivial cleanups and fixes”
  1. 0/4 completion: trivial cleanups and fixesFelipe Contreras, Apr 12, 2012
  2. 1/4 completion: simplify __gitcomp_1Felipe Contreras, Apr 12, 2012
  3. 2/4 completion: trivial simplificationFelipe Contreras, Apr 12, 2012
  4. 3/4 completion: add missing general optionsFelipe Contreras, Apr 12, 2012
  5. 4/4 completion: improve 'git --exec-path' completionFelipe Contreras, Apr 12, 2012
  6. Jonathan NiederApr 13, 2012
  7. Jonathan NiederApr 13, 2012
  8. Jonathan NiederApr 13, 2012
  9. Felipe ContrerasApr 13, 2012
  10. Jonathan NiederApr 13, 2012
  11. Felipe ContrerasApr 13, 2012
  12. Andreas SchwabApr 14, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.