Re: [PATCH v5 3/3] gitweb: add If-Modified-Since handling to git_snapshot().

> On Mon, 26 Mar 2012, W. Trevor King wrote:
> > Because snapshots can be large, you can save some bandwidth by
> > supporting caching via If-Modified-Since.  This patch adds support for
> > the i-m-s request to git_snapshot() if the requested hash is a commit.
> 
> "if the requested hash is a commit" means here "if we request snapshot
> of a commit", isn't it?
> 
> > Requests for snapshots of tree-ishes, which lack well defined
> > timestamps, are still handled as they were before.
> 
> s/tree-ishes/trees/.  Commit is tree-ish but not a tree; it is tree
> that lacks timestamp that commit has.

> > +	if (%co) {
> > +		my %latest_date = parse_date($co{'committer_epoch'}, $co{'committer_tz'});
> > +		print $cgi->header(
> > +			-type => $known_snapshot_formats{$format}{'type'},
> > +			-content_disposition => 'inline; filename="' . $filename . '"',
> > +			-last_modified => $latest_date{'rfc2822'},
> > +			-status => '200 OK');
> > +	} else {
> > +		print $cgi->header(
> > +			-type => $known_snapshot_formats{$format}{'type'},
> > +			-content_disposition => 'inline; filename="' . $filename . '"',
> > +			-status => '200 OK');
> > +	}
> 
> This can be written shorter, and with less code repetition using ?: 
> conditional operator:
> 
> > +	print $cgi->header(
> > +		-type => $known_snapshot_formats{$format}{'type'},
> > +		-content_disposition => 'inline; filename="' . $filename . '"',
> > +		 (%co ? -last_modified => $latest_date{'rfc2822'} : ()),
> > +		-status => '200 OK');
> 
> ...or something like that.