git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] Isolate If-Modified-Since handling in gitweb

From
W. Trevor King <wking@drexel.edu>
Date
Mar 21, 2012, 19:55 UTC
Message-ID
<20120321195520.GB32535@odin.tremily.us>
In-Reply-To
<7vmx7921yz.fsf@alter.siamese.dyndns.org>
On Wed, Mar 21, 2012 at 12:22:44PM -0700, Junio C Hamano wrote:
Show 14 quoted lines
> "W. Trevor King" <wking@drexel.edu> writes:
> >> I think it would be better to add initial tests with refactoring, and
> >> snapshot specific tests with snapshot support, e.g.:
> >> 
> >>   1/2: gitweb: Refactor If-Modified-Since handling and add tests
> >>   2/2: gitweb: Add If-Modified-Since support for snapshots
> >
> > But the new tests would be for the new functionality (i.e. snapshot
> > support), so they wouldn't belong in the general refactoring commit.
> 
> Then you are planning to split it in a wrong way.
> 
> ... add tests for codepaths that use i-m-s to make sure your
> refactoring did not break them...

Ah, I was assuming that some current tests might be checking the current behavior, and that my new tests would be testing my new snapshot behavior. If the old i-m-s handling also needs tests, that should happen before any of my previously proposed patches:

1: tests for i-m-s and git_feed 2: refactor i-m-s handling 3: tests for i-m-s and git_snapshot (which fail until 4) 4: add i-m-s to git_snapshot

How does that sound?
-- 
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy
Previous: Junio C HamanoNext: Jakub Narebski
Message 11 of 43 in “What's cooking in git.git (Mar 2012, #07; Mon, 19)”
  1. Junio C HamanoMar 20, 2012
  2. W. Trevor KingMar 20, 2012
  3. Junio C HamanoMar 20, 2012
  4. Incremental updates to What's cookingJunio C Hamano, Mar 20, 2012
  5. Isolate If-Modified-Since handling in gitwebW. Trevor King, Mar 21, 2012
  6. Jakub NarebskiMar 21, 2012
  7. W. Trevor KingMar 21, 2012
  8. Jakub NarebskiMar 21, 2012
  9. W. Trevor KingMar 21, 2012
  10. Junio C HamanoMar 21, 2012
  11. W. Trevor KingMar 21, 2012
  12. Jakub NarebskiMar 21, 2012
  13. Junio C HamanoMar 21, 2012
  14. W. Trevor KingMar 21, 2012
  15. Jakub NarebskiMar 22, 2012
  16. Junio C HamanoMar 21, 2012
  17. Jakub NarebskiMar 22, 2012
  18. Junio C HamanoMar 22, 2012
  19. W. Trevor KingMar 26, 2012
  20. 1/3 gitweb: add `status` headers to git_feed() responses.W. Trevor King, Mar 26, 2012
  21. 2/3 gitweb: refactor If-Modified-Since handlingW. Trevor King, Mar 26, 2012
  22. Junio C HamanoMar 26, 2012
  23. W. Trevor KingMar 26, 2012
  24. Junio C HamanoMar 26, 2012
  25. W. Trevor KingMar 26, 2012
  26. Jakub NarebskiMar 27, 2012
  27. W. Trevor KingMar 28, 2012
  28. Jakub NarebskiMar 28, 2012
  29. 0/3 gitweb: refactor If-Modified-Since handlingwking@tremily.us, Mar 28, 2012
  30. W. Trevor KingMar 28, 2012
  31. 1/3 gitweb: add `status` headers to git_feed() responses.wking@tremily.us, Mar 28, 2012
  32. 2/3 gitweb: refactor If-Modified-Since handlingwking@tremily.us, Mar 28, 2012
  33. 3/3 gitweb: add If-Modified-Since handling to git_snapshot().wking@tremily.us, Mar 28, 2012
  34. Jakub NarebskiMar 28, 2012
  35. W. Trevor KingMar 26, 2012
  36. Jakub NarebskiMar 27, 2012
  37. W. Trevor KingMar 28, 2012
  38. 3/3 gitweb: add If-Modified-Since handling to git_snapshot().W. Trevor King, Mar 26, 2012
  39. Jakub NarebskiMar 27, 2012
  40. W. Trevor KingMar 27, 2012
  41. Jakub NarebskiMar 27, 2012
  42. W. Trevor KingMar 27, 2012
  43. Junio C HamanoMar 27, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.