git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] tests: unset COLUMNS inherited from environment

From
Jeff King <peff@peff.net>
Date
Mar 27, 2012, 18:44 UTC
Message-ID
<20120327184426.GC8460@sigill.intra.peff.net>
In-Reply-To
<1332829323-6048-1-git-send-email-zbyszek@in.waw.pl>
On Tue, Mar 27, 2012 at 08:22:02AM +0200, Zbigniew Jędrzejewski-Szmek wrote:
Show 9 quoted lines
> $COLUMNS must be unset to not interfere with the tests. The tests
> already ignore the terminal size because output is redirected to a
> file, but COLUMNS overrides terminal size detection and changes the
> test output away from the standard 80.
> 
> Reported-by: Jeff King <peff@peff.net>
> Signed-off-by: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
> ---
> Right, it is better to unset $COLUMNS globally. t4016 was also affected.
Thanks. Solves the problem for me, and looks obviously correct.
-Peff
Previous: Zbigniew Jędrzejewski-SzmekNext: Johannes Sixt
Message 19 of 23 in “Incremental updates to What's cooking”
  1. Junio C HamanoFeb 28, 2012
  2. Zbigniew Jędrzejewski-SzmekFeb 29, 2012
  3. Junio C HamanoFeb 29, 2012
  4. Zbigniew Jędrzejewski-SzmekFeb 29, 2012
  5. Junio C HamanoFeb 29, 2012
  6. Zbigniew Jędrzejewski-SzmekFeb 29, 2012
  7. Junio C HamanoFeb 29, 2012
  8. 1/9 diff --stat: tests for long filenames and big change countsZbigniew Jędrzejewski-Szmek, Mar 1, 2012
  9. 2/9 diff --stat: use the full terminal widthZbigniew Jędrzejewski-Szmek, Mar 1, 2012
  10. 3/9 show --stat: use the full terminal widthZbigniew Jędrzejewski-Szmek, Mar 1, 2012
  11. 4/9 log --stat: use the full terminal widthZbigniew Jędrzejewski-Szmek, Mar 1, 2012
  12. 5/9 merge --stat: use the full terminal widthZbigniew Jędrzejewski-Szmek, Mar 1, 2012
  13. 6/9 diff --stat: use a maximum of 5/8 for the filename partZbigniew Jędrzejewski-Szmek, Mar 1, 2012
  14. Junio C HamanoMar 1, 2012
  15. Jeff KingMar 26, 2012
  16. t4052: unset $COLUMNS inherited from environmentZbigniew Jędrzejewski-Szmek, Mar 27, 2012
  17. Jeff KingMar 27, 2012
  18. tests: unset COLUMNS inherited from environmentZbigniew Jędrzejewski-Szmek, Mar 27, 2012
  19. Jeff KingMar 27, 2012
  20. Johannes SixtMar 27, 2012
  21. 7/9 diff --stat: add a test for output with COLUMNS=40Zbigniew Jędrzejewski-Szmek, Mar 1, 2012
  22. 8/9 diff --stat: enable limiting of the graph partZbigniew Jędrzejewski-Szmek, Mar 1, 2012
  23. 9/9 diff --stat: add config option to limit graph widthZbigniew Jędrzejewski-Szmek, Mar 1, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.