From: Jeff King Date: Tue, 27 Mar 2012 18:44:26 GMT Subject: Re: [PATCH v2] tests: unset COLUMNS inherited from environment Message-ID: <20120327184426.GC8460@sigill.intra.peff.net> In-Reply-To: <1332829323-6048-1-git-send-email-zbyszek@in.waw.pl> On Tue, Mar 27, 2012 at 08:22:02AM +0200, Zbigniew Jędrzejewski-Szmek wrote: > $COLUMNS must be unset to not interfere with the tests. The tests > already ignore the terminal size because output is redirected to a > file, but COLUMNS overrides terminal size detection and changes the > test output away from the standard 80. > > Reported-by: Jeff King > Signed-off-by: Zbigniew Jędrzejewski-Szmek > --- > Right, it is better to unset $COLUMNS globally. t4016 was also affected. Thanks. Solves the problem for me, and looks obviously correct. -Peff