Re: [PATCH] t4052: unset $COLUMNS inherited from environment

From: Jeff King <peff@peff.net>
Date: Mar 27, 2012, 05:17 UTC
Message-ID: <20120327051714.GB20897@sigill.intra.peff.net>
In-Reply-To: <1332825003-2288-1-git-send-email-zbyszek@in.waw.pl>

On Tue, Mar 27, 2012 at 07:10:03AM +0200, Zbigniew Jędrzejewski-Szmek wrote:

Show 9 quoted lines

> $COLUMNS must be unset to not interfere with the tests. The tests
> already ignore the terminal size because output is redirected to a
> file, but $COLUMNS overrides terminal size detection and changes the
> test output away from the standard 80 even if not on a terminal.
> 
> Reported-by: Jeff King <peff@peff.net>
> Signed-off-by: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
> ---
> Stupid omission. Please apply.

Thanks. I had a feeling it was something like this, but when I went to test again, I couldn't reproduce! It seems that COLUMNS is not exported by default, but somehow I must have exported it accidentally.

Show 10 quoted lines

> diff --git a/t/t4052-stat-output.sh b/t/t4052-stat-output.sh
> index 328aa8f..1f47f1d 100755
> --- a/t/t4052-stat-output.sh
> +++ b/t/t4052-stat-output.sh
> @@ -17,6 +17,7 @@ test_expect_success 'preparation' '
>  	git commit -m message &&
>  	echo a >"$name" &&
>  	git commit -m message "$name"
> +	sane_unset COLUMNS
>  '

Should we perhaps just unset it in test-lib.sh, along with the other variables that cause an inconsistent test environment? This is the only test script that breaks now, but there's no reason not to protect all of the scripts.

-Peff