[PATCH 2/2] t0300: use write_script helper
- From
Jeff King <peff@peff.net>
- Date
- Feb 4, 2012, 06:30 UTC
- Message-ID
- <20120204063018.GB21559@sigill.intra.peff.net>
- In-Reply-To
- <20120204062712.GA20076@sigill.intra.peff.net>
t0300 creates some helper shell scripts, and marks them with "!/bin/sh". Even though the scripts are fairly simple, they can fail on broken shells (specifically, Solaris /bin/sh will persist a temporary assignment to IFS in a "read" command).
Rather than work around the problem for Solaris /bin/sh, using write_script will make sure we point to a known-good shell that the user has given us.
Signed-off-by: Jeff King <peff@peff.net> --- This works fine on my Linux box, but just to sanity check that I didn't screw anything up in the whopping 5 lines of changes, can you confirm this fixes the issue for you, Ben?
t/t0300-credentials.sh | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/t/t0300-credentials.sh b/t/t0300-credentials.sh index 885af8f..0b46248 100755 --- a/t/t0300-credentials.sh +++ b/t/t0300-credentials.sh @@ -14,14 +14,13 @@ test_expect_success 'setup helper scripts' ' done EOF - cat >git-credential-useless <<-\EOF && + write_script git-credential-useless <<-\EOF && #!/bin/sh . ./dump exit 0 EOF - chmod +x git-credential-useless && - cat >git-credential-verbatim <<-\EOF && + write_script git-credential-verbatim <<-\EOF && #!/bin/sh user=$1; shift pass=$1; shift @@ -29,7 +28,6 @@ test_expect_success 'setup helper scripts' ' test -z "$user" || echo username=$user test -z "$pass" || echo password=$pass EOF - chmod +x git-credential-verbatim && PATH="$PWD:$PATH" '
-- 1.7.9.rc1.28.gf4be5