Re: [PATCH] t0300-credentials: Word around a solaris /bin/sh bug

From: Jeff King <peff@peff.net>
Date: Feb 3, 2012, 21:26 UTC
Message-ID: <20120203212604.GA1890@sigill.intra.peff.net>
In-Reply-To: <7v7h03odyo.fsf@alter.siamese.dyndns.org>

On Fri, Feb 03, 2012 at 12:32:15PM -0800, Junio C Hamano wrote:

Show 17 quoted lines

> I am toying with the pros-and-cons of
> 
> 	write_script () {
> 		echo "#!$1"
> 		shift
>                 cat
> 	}
> 
> so that the above can become
> 
> 	write_script "$SHELL_PATH" >foo.sh <<-EOF
>         echo my arguments are "\$@"
> 	EOF
> 
> without requiring the brain-cycle to waste on the "Is this simple enough
> for even Solaris to grok?" guess game.  This should also be reusable for
> other stuff like $PERL_PATH, I would think.

I like it. Even better would be:

  write_script() {
        echo "#!$2" >"$1" &&
        cat >>"$1" &&
        chmod +x "$1"
  }

  write_script foo.sh "$SHELL_PATH" <<-\EOF
    echo my arguments are "$@"
  EOF

-Peff