Re: [PATCH] t0300-credentials: Word around a solaris /bin/sh bug

From: Ben Walton <bwalton@artsci.utoronto.ca>
Date: Feb 3, 2012, 22:00 UTC
Message-ID: <1328306228-sup-8799@pinkfloyd.chass.utoronto.ca>
In-Reply-To: <20120203215507.GB3472@sigill.intra.peff.net>

Excerpts from Jeff King's message of Fri Feb 03 16:55:07 -0500 2012:

Show 18 quoted lines

> >     write_script () {
> >         case "$#" in
> >         1)    case "$1" in
> >             *.perl | *.pl) echo "#!$PERL_PATH" ;;
> >             *) echo "#!$SHELL_PATH" ;;
> >             esac
> >                 2)    echo "#!$2" ;;
> >         *)    BUG ;;
> >                 esac >"$1" &&
> >                 cat >>"$1" &&
> >                 chmod +x "$1"
> >     }
> > 
> 
> Nice. I was going to suggest a wrapper like "write_sh_script" so you
> didn't have to spell out $SHELL_PATH, but I think the auto-detection
> makes sense (and falling back to shell makes even more sense, as that
> covers 99% of the cases anyway).

This looks like a very nice, general purpose, solution to the problem.

Thanks -Ben -- Ben Walton Systems Programmer - CHASS University of Toronto C:416.407.5610 | W:416.978.4302