Re: [BUG] git archive broken in 1.7.8.1

From: Jeff King <peff@peff.net>
Date: Jan 10, 2012, 23:21 UTC
Message-ID: <20120110232132.GA29245@sigill.intra.peff.net>
In-Reply-To: <20120110225011.GJ2714@centaur.lab.cmartin.tk>

On Tue, Jan 10, 2012 at 11:50:11PM +0100, Carlos Martín Nieto wrote:

Show 16 quoted lines

> > Unfortunately this producess a tarball with a different layout, e.g.
> > 
> > git archive --remote=git://anongit.kde.org/kgraphviewer.git HEAD:doc/en_US
> >   gives me a tarball with the doc/en_US files in the root
> > 
> > git archive --remote=git://anongit.kde.org/kgraphviewer.git HEAD -- doc/en_US
> >   gives me a tarball with the doc/en_US folders and then the files
> > 
> > Is there a way to keep the old behaviour or do we need to update our scripts?
> 
> Not as far as I know. However, the commit that hardened the input
> (ee27ca4a781844: archive: don't let remote clients get unreachable
> commits, 2011-11-17) does state that HEAD:doc/en_US should be valid,
> so it looks like it's actually a regression. As it's bedtime in my
> timezone, I'm blaming Peff and I'll look into this if it hasn't been
> fixed by the time I get to the office tomorrow.

It is definitely my fault. According to ee27ca4a, sub-trees were an unfortunate casualty of the tightening. However, I did have some patches that moved towards allowing things like that safely (basically the rev parser needs to pass more context back to the caller).

It's evening here and I'm doing family stuff, but I'll take a look either late tonight or tomorrow morning.

-Peff