Re: [BUG] git archive broken in 1.7.8.1

From: Carlos Martín Nieto <cmn@elego.de>
Date: Jan 10, 2012, 22:50 UTC
Message-ID: <20120110225011.GJ2714@centaur.lab.cmartin.tk>
In-Reply-To: <1431498.0yPWNQLupF@xps>

On Tue, Jan 10, 2012 at 11:05:45PM +0100, Albert Astals Cid wrote:

Show 24 quoted lines

> El Dimarts, 10 de gener de 2012, a les 22:33:44, Carlos Martín Nieto va 
> escriure:
> > On Tue, Jan 10, 2012 at 10:18:41PM +0100, Albert Astals Cid wrote:
> > > CC me on answers since i'm not subscribed to the list
> > > 
> > > Hi, one of our [KDE] anongit servers was updated to 1.7.8.1 and not the
> > > syntax
> > > 
> > > git archive --remote=git://anongit.kde.org/repo.git HEAD:path
> > 
> > This syntax is no longer allowed due to some security tightening. Use
> > the alternate syntax
> > 
> >     git archive --remote=git://anongit.kde.org/repo.git HEAD -- path
> 
> Unfortunately this producess a tarball with a different layout, e.g.
> 
> git archive --remote=git://anongit.kde.org/kgraphviewer.git HEAD:doc/en_US
>   gives me a tarball with the doc/en_US files in the root
> 
> git archive --remote=git://anongit.kde.org/kgraphviewer.git HEAD -- doc/en_US
>   gives me a tarball with the doc/en_US folders and then the files
> 
> Is there a way to keep the old behaviour or do we need to update our scripts?

Not as far as I know. However, the commit that hardened the input (ee27ca4a781844: archive: don't let remote clients get unreachable commits, 2011-11-17) does state that HEAD:doc/en_US should be valid, so it looks like it's actually a regression. As it's bedtime in my timezone, I'm blaming Peff and I'll look into this if it hasn't been fixed by the time I get to the office tomorrow.

Show 11 quoted lines

> 
> Thanks for the fast answer!
> 
> Albert
> 
> > 
> > > does not seem to return a valid tar archive anymore when it did work
> > > previously. In fact the man page of my version has that syntax in one of
> > > the examples.
> > 
> > That sounds like a documentation bug.

Notice that the syntax is for the local case, not for --remote.

cmn