git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rebase --fix: interactive fixup mode

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Jan 9, 2012, 08:43 UTC
Message-ID
<20120109084309.GD23422@burratino>
In-Reply-To
<CACsJy8CKK0EAy79Fahi64bUw2kfr=eunegbeA7oX_XaXEBFr2g@mail.gmail.com>
Nguyen Thai Ngoc Duy wrote:
> Is something like this over-generalized?
>
> http://kerneltrap.org/mailarchive/git/2010/12/24/47502

Yes, I suspect that at the moment (i.e., in the absence of a large collection of examples to show their utility), both your ^{~custom} and my ^{first:rev-list args} are overengineered, and that they do something that is more clearly expressed using the shell's command substitution feature:

	git rebase -i $(git rev-list --merges HEAD | head -1)
So why did I suggest it?

I guess I was reacting to the implementation of the rebase-recent-commits command. I understand that it was a sketch, but it felt a little ad hoc. If it could be expressed as a clean two-liner, I would be more comfortable since the burden of maintaining it would be less.

Thanks for clarifying.

Sincerely, Jonathan

Previous: Nguyen Thai Ngoc DuyNext: Junio C Hamano
Message 7 of 13 in “rebase --fix: interactive fixup mode”
  1. rebase --fix: interactive fixup modeClemens Buchacher, Jan 8, 2012
  2. Jakub NarebskiJan 8, 2012
  3. Clemens BuchacherJan 8, 2012
  4. Jonathan NiederJan 8, 2012
  5. Clemens BuchacherJan 8, 2012
  6. Nguyen Thai Ngoc DuyJan 9, 2012
  7. Jonathan NiederJan 9, 2012
  8. Junio C HamanoJan 8, 2012
  9. Clemens BuchacherJan 9, 2012
  10. Michael HaggertyJan 9, 2012
  11. Neal KreitzingerJan 10, 2012
  12. Thomas RastJan 9, 2012
  13. Clemens BuchacherJan 9, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.