git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/5] Re-roll rr/revert-cherry-pick

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Dec 7, 2011, 09:56 UTC
Message-ID
<20111207095636.GA13374@elie.hsd1.il.comcast.net>
In-Reply-To
<CALkWK0k+GF9qjwYd_TzA3o8FqAH6G+cxREZ5r9x8E2G5k-mmmg@mail.gmail.com>
Ramkumar Ramachandra wrote:
> I suppose they were a combination of all three.  I'm sorry- I'll try
> to be more careful and communicative in the future.

Hm, that is not exactly what I was going for, either. First, I didn't mean to harp on anything in the past --- it was a request regarding this current review. And on the other hand, I am not sure it is a matter of you being uncareful or uncommunicative, exactly. It's more that _I_ am doing a poor job of clearly conveying what Junio described as easier to learn on one's own at [1].

To put it more concretely:

I am going to be stubborn. I will not ack a patch unless I can imagine myself, years from now, after running into a bug in a related area, not being confused by it.

[1] http://thread.gmane.org/gmane.comp.version-control.git/186402/focus=186415
Previous: Ramkumar RamachandraNext: Jonathan Nieder
Message 21 of 23 in “Re-roll rr/revert-cherry-pick”
  1. 0/5 Re-roll rr/revert-cherry-pickRamkumar Ramachandra, Dec 7, 2011
  2. 1/5 revert: free msg in format_todo()Ramkumar Ramachandra, Dec 7, 2011
  3. Jonathan NiederDec 7, 2011
  4. 2/5 revert: make commit subjects in insn sheet optionalRamkumar Ramachandra, Dec 7, 2011
  5. Jonathan NiederDec 7, 2011
  6. Ramkumar RamachandraDec 9, 2011
  7. Ramkumar RamachandraDec 9, 2011
  8. Jonathan NiederDec 9, 2011
  9. Ramkumar RamachandraDec 9, 2011
  10. Jonathan NiederDec 9, 2011
  11. Ramkumar RamachandraDec 9, 2011
  12. 3/5 revert: simplify getting commit subject in format_todo()Ramkumar Ramachandra, Dec 7, 2011
  13. Jonathan NiederDec 7, 2011
  14. 4/5 revert: allow mixed pick and revert instructionsRamkumar Ramachandra, Dec 7, 2011
  15. Jonathan NiederDec 7, 2011
  16. Ramkumar RamachandraDec 9, 2011
  17. 5/5 revert: simplify communicating command-line argumentsRamkumar Ramachandra, Dec 7, 2011
  18. Jonathan NiederDec 7, 2011
  19. Jonathan NiederDec 7, 2011
  20. Ramkumar RamachandraDec 7, 2011
  21. Jonathan NiederDec 7, 2011
  22. Jonathan NiederDec 7, 2011
  23. Junio C HamanoDec 8, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.