git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/5] Re-roll rr/revert-cherry-pick

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Dec 7, 2011, 08:28 UTC
Message-ID
<20111207082822.GH11737@elie.hsd1.il.comcast.net>
In-Reply-To
<20111207081734.GG11737@elie.hsd1.il.comcast.net>
Jonathan Nieder wrote:
> Fine.  But I would like to know which case they fell into, so I can
> learn in order to do a better job reviewing the future and know my
                                             ^in
> time is well spent.

Sorry for the nonsense. :) And now that I look back over previous revisions of the patches, I see that I _hadn't_ clearly complained about the same aspects of these particular commit messages before. So what am I talking about here?

I guess it is just a pattern: commit messages I have looked at in the sequencer series lately seem to focus too much on implementation details and not enough on the "big picture" of what the user or internal API user will experience. One symptom is that I get lost in reading the commit message without looking at the patch. Another symptom is that the commit messages tend to mention the particular (private) functions that were changed, instead of the more prominent (often public) callers that the reader might have cause to call.

Hoping that clarifies a little, Jonathan

Previous: Jonathan NiederNext: Junio C Hamano
Message 22 of 23 in “Re-roll rr/revert-cherry-pick”
  1. 0/5 Re-roll rr/revert-cherry-pickRamkumar Ramachandra, Dec 7, 2011
  2. 1/5 revert: free msg in format_todo()Ramkumar Ramachandra, Dec 7, 2011
  3. Jonathan NiederDec 7, 2011
  4. 2/5 revert: make commit subjects in insn sheet optionalRamkumar Ramachandra, Dec 7, 2011
  5. Jonathan NiederDec 7, 2011
  6. Ramkumar RamachandraDec 9, 2011
  7. Ramkumar RamachandraDec 9, 2011
  8. Jonathan NiederDec 9, 2011
  9. Ramkumar RamachandraDec 9, 2011
  10. Jonathan NiederDec 9, 2011
  11. Ramkumar RamachandraDec 9, 2011
  12. 3/5 revert: simplify getting commit subject in format_todo()Ramkumar Ramachandra, Dec 7, 2011
  13. Jonathan NiederDec 7, 2011
  14. 4/5 revert: allow mixed pick and revert instructionsRamkumar Ramachandra, Dec 7, 2011
  15. Jonathan NiederDec 7, 2011
  16. Ramkumar RamachandraDec 9, 2011
  17. 5/5 revert: simplify communicating command-line argumentsRamkumar Ramachandra, Dec 7, 2011
  18. Jonathan NiederDec 7, 2011
  19. Jonathan NiederDec 7, 2011
  20. Ramkumar RamachandraDec 7, 2011
  21. Jonathan NiederDec 7, 2011
  22. Jonathan NiederDec 7, 2011
  23. Junio C HamanoDec 8, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.