git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/5] revert: make commit subjects in insn sheet optional

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Dec 7, 2011, 07:02 UTC
Message-ID
<20111207070223.GC11737@elie.hsd1.il.comcast.net>
In-Reply-To
<1323239877-24101-3-git-send-email-artagnon@gmail.com>
Ramkumar Ramachandra wrote:
Show 15 quoted lines
> Change the instruction sheet format subtly so that the subject of the
> commit message that follows the object name is optional.  As a result,
> an instruction sheet like this is now perfectly valid:
>
>   pick 35b0426
>   pick fbd5bbcbc2e
>   pick 7362160f
>
> While at it, also fix a bug: currently, we use a commit-id-shaped
> buffer to store the word after "pick" in '.git/sequencer/todo'.  This
> is both wasteful and wrong because it places an artificial limit on
> the line length.  Eliminate the need for the buffer altogether, and
> add a test demonstrating this.
>
> [jc: simplify parsing]

Reading the above does not make it at all obvious that I should want to apply this patch because otherwise my prankster friend can cause my copy of git to crash or run arbitrary code by putting a long commit name in .git/sequencer/todo in our NFS-mounted shared checkout.

(Yes, I know there are other problems with such a setup, especially if .git/hooks or .git/config is writable by untrusted people. So it is not actually a security bug, but a robustness one.)

Previous: Ramkumar RamachandraNext: Ramkumar Ramachandra
Message 5 of 23 in “Re-roll rr/revert-cherry-pick”
  1. 0/5 Re-roll rr/revert-cherry-pickRamkumar Ramachandra, Dec 7, 2011
  2. 1/5 revert: free msg in format_todo()Ramkumar Ramachandra, Dec 7, 2011
  3. Jonathan NiederDec 7, 2011
  4. 2/5 revert: make commit subjects in insn sheet optionalRamkumar Ramachandra, Dec 7, 2011
  5. Jonathan NiederDec 7, 2011
  6. Ramkumar RamachandraDec 9, 2011
  7. Ramkumar RamachandraDec 9, 2011
  8. Jonathan NiederDec 9, 2011
  9. Ramkumar RamachandraDec 9, 2011
  10. Jonathan NiederDec 9, 2011
  11. Ramkumar RamachandraDec 9, 2011
  12. 3/5 revert: simplify getting commit subject in format_todo()Ramkumar Ramachandra, Dec 7, 2011
  13. Jonathan NiederDec 7, 2011
  14. 4/5 revert: allow mixed pick and revert instructionsRamkumar Ramachandra, Dec 7, 2011
  15. Jonathan NiederDec 7, 2011
  16. Ramkumar RamachandraDec 9, 2011
  17. 5/5 revert: simplify communicating command-line argumentsRamkumar Ramachandra, Dec 7, 2011
  18. Jonathan NiederDec 7, 2011
  19. Jonathan NiederDec 7, 2011
  20. Ramkumar RamachandraDec 7, 2011
  21. Jonathan NiederDec 7, 2011
  22. Jonathan NiederDec 7, 2011
  23. Junio C HamanoDec 8, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.