git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: imap-send badly handles commit bodies beginning with "From <"

From
Jeff King <peff@peff.net>
Date
Oct 28, 2011, 20:32 UTC
Message-ID
<20111028203256.GA15082@sigill.intra.peff.net>
In-Reply-To
<20111028180044.GA3966@foghorn.codeweavers.com>
On Fri, Oct 28, 2011 at 01:00:44PM -0500, Andrew Eikum wrote:
Show 5 quoted lines
> On the server side, it was split into two mails on either side of that
> commit message's From line with neither mail actually containing the
> From line. To fix it, I just changed it to "Copied from <url>:" :-P
> 
> Ain't mbox grand?

Mbox does have this problem, but I think in this case it is a particularly crappy implementation of mbox in imap-send. Look at imap-send.c:split_msg; it just looks for "From ".

It should at least check for something that looks like a timestamp, like git-mailsplit does. Maybe mailsplit's is_from_line should be factored out so that it can be reused in imap-send.

Want to work on a patch?
-Peff
Previous: Andrew EikumNext: Andrew Eikum
Message 2 of 8 in “imap-send badly handles commit bodies beginning with "From <"”
  1. Andrew EikumOct 28, 2011
  2. Jeff KingOct 28, 2011
  3. Andrew EikumOct 28, 2011
  4. Jeff KingOct 28, 2011
  5. Magnus BäckOct 30, 2011
  6. Jeff KingNov 1, 2011
  7. Michael HaggertyNov 1, 2011
  8. Jeff KingNov 1, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.