git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: imap-send badly handles commit bodies beginning with "From <"

From
AEAndrew Eikum <aeikum@codeweavers.com>
Date
Oct 28, 2011, 21:21 UTC
Message-ID
<20111028212122.GB3966@foghorn.codeweavers.com>
In-Reply-To
<20111028203256.GA15082@sigill.intra.peff.net>
On Fri, Oct 28, 2011 at 01:32:57PM -0700, Jeff King wrote:
Show 7 quoted lines
> Mbox does have this problem, but I think in this case it is a
> particularly crappy implementation of mbox in imap-send. Look at
> imap-send.c:split_msg; it just looks for "From ".
> 
> It should at least check for something that looks like a timestamp, like
> git-mailsplit does. Maybe mailsplit's is_from_line should be factored
> out so that it can be reused in imap-send.

Since we have a program called "mailsplit," wouldn't it make more sense to have imap-send use its implementation to split mail instead of sharing just the From line detection?

> Want to work on a patch?

I was hoping it'd be a quick matter of pulling mailsplit's implementation out of builtin and into the top level, but I see it's got some global variables that are tangled enough that I actually have to understand the code before I can pull it apart :)

If no one beats me to it, I'll work on this next week. It's late on Friday and I'm moving house this weekend.

Quick question, since I'm not intimately familiar with Git's code: I was thinking of creating a new compilation unit at the top level, mailutils.{c,h}, and referencing it from both imap-send.c and builtin/splitmail.c. Does that seem like the right approach? Is there an existing compilation unit I should be placing splitmail's guts into instead?

Andrew
Previous: Jeff KingNext: Jeff King
Message 3 of 8 in “imap-send badly handles commit bodies beginning with "From <"”
  1. Andrew EikumOct 28, 2011
  2. Jeff KingOct 28, 2011
  3. Andrew EikumOct 28, 2011
  4. Jeff KingOct 28, 2011
  5. Magnus BäckOct 30, 2011
  6. Jeff KingNov 1, 2011
  7. Michael HaggertyNov 1, 2011
  8. Jeff KingNov 1, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.