From: Jeff King <peff@peff.net>
Date: Fri, 28 Oct 2011 20:32:57 GMT
Subject: Re: imap-send badly handles commit bodies beginning with "From <"
Message-ID: <20111028203256.GA15082@sigill.intra.peff.net>
In-Reply-To: <20111028180044.GA3966@foghorn.codeweavers.com>

On Fri, Oct 28, 2011 at 01:00:44PM -0500, Andrew Eikum wrote:

> On the server side, it was split into two mails on either side of that
> commit message's From line with neither mail actually containing the
> From line. To fix it, I just changed it to "Copied from <url>:" :-P
> 
> Ain't mbox grand?

Mbox does have this problem, but I think in this case it is a
particularly crappy implementation of mbox in imap-send. Look at
imap-send.c:split_msg; it just looks for "From ".

It should at least check for something that looks like a timestamp, like
git-mailsplit does. Maybe mailsplit's is_from_line should be factored
out so that it can be reused in imap-send.

Want to work on a patch?

-Peff