git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] credential-cache--daemon.c: Don't leave stale socket on --exit

From
Jeff King <peff@peff.net>
Date
Oct 22, 2011, 19:17 UTC
Message-ID
<20111022191711.GC1785@sigill.intra.peff.net>
In-Reply-To
<4EA2FC63.9060602@ramsay1.demon.co.uk>
On Sat, Oct 22, 2011 at 06:24:51PM +0100, Ramsay Jones wrote:
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> ---
>  credential-cache--daemon.c |   23 ++++++++++++-----------
>  1 files changed, 12 insertions(+), 11 deletions(-)

Looks sane, and I'll probably squash it in. Alternatively, we could also set a signal/exit handler to clean up our socket when we die. That would also cover the error exit cases.

In either case, I think we need to handle stale sockets better. They will happen eventually due to power loss or kill -9, anyway.

-Peff
Previous: Ramsay JonesNext: Ramsay Jones
Message 2 of 4 in “credential-cache--daemon.c: Don't leave stale socket on --exit”
  1. 1/2 credential-cache--daemon.c: Don't leave stale socket on --exitRamsay Jones, Oct 22, 2011
  2. Jeff KingOct 22, 2011
  3. Ramsay JonesOct 27, 2011
  4. Jeff KingOct 27, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.