Re: [PATCH 1/2] credential-cache--daemon.c: Don't leave stale socket on --exit

From: Jeff King <peff@peff.net>
Date: Oct 27, 2011, 17:42 UTC
Message-ID: <20111027174208.GB1967@sigill.intra.peff.net>
In-Reply-To: <4EA9950A.9020208@ramsay1.demon.co.uk>

On Thu, Oct 27, 2011 at 06:29:46PM +0100, Ramsay Jones wrote:

Show 14 quoted lines

> Jeff King wrote:
> > On Sat, Oct 22, 2011 at 06:24:51PM +0100, Ramsay Jones wrote:
> > 
> >> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> >> ---
> >>  credential-cache--daemon.c |   23 ++++++++++++-----------
> >>  1 files changed, 12 insertions(+), 11 deletions(-)
> > 
> > Looks sane, and I'll probably squash it in. Alternatively, we could also
> > set a signal/exit handler to clean up our socket when we die. That would
> > also cover the error exit cases.
> 
> I considered this, *very* briefly, but decided it wasn't worth the effort
> or complexity.

Actually, I think with the sigchain code, it would only end up as a few lines. I'll probably take a look when I re-roll.

Thanks for your patches.

-Peff